search

christianbarkowsky / contao-tabcontrol

Contao Extension :: Tabcontrol
https://brkwsky.de/tabcontrol-contao
8 stars 4 forks source link

Scroll to Tab only on second click #36

Open falkgeist opened 5 years ago

falkgeist commented 5 years ago

Might be connected to #18

I have a button further up on a onepager (tabs and panes are offpage), linking to a not-active tab with id="reiter-2".

The expected behaviour is, when I click the button, the tab with the id="reiter-2" is set active (=opens) AND scrolls to the pane of that tab.

But at the moment, the first click opens the pane, the second click (when the pane is active) scrolls the view to the pane.

I am not a jquery/mootools/javascript/php professional, only looking at the code every time something doesn't work.

Maybe this is working as intended, but I definitely need the behaviour to work as mentioned. Almost nobody will understand that the first click only opened the pane and just think "the button doesn't work".

Thanks for looking into this.

falkgeist commented 4 years ago

Running across the issue again, just to see that nothing happened since I opened this issue. Too bad to see that this repository is dead... :(

christianbarkowsky commented 4 years ago

This repository is not dead, but other tasks are more important. You can make a pull request. @Falkgeist

falkgeist commented 4 years ago

This repository is not dead

Ah, okay, not dead, very good. :)

but other tasks are more important. You can make a pull request.

Okay, I understand that. Sadly, same here, no time to dive into your code and try to fix it. :( I'll check it out, when I have more time for troubleshooting.