christianbastin / jackrabbitexplorer

Automatically exported from code.google.com/p/jackrabbitexplorer
0 stars 1 forks source link

Click to Open a binary file from a jcr:content node replaces the current window #25

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Browse to a jcr:content node
2. Click on the jcr:data property in the property tab to download

What is the expected output? What do you see instead?

Expect content opened in new window, rather than the current. As the code calls 
Window.Location.replace the current window containing the JR Explorer is 
replaced (lost). To go back to where you were you have to reload the whole 
explorer

The fix would be to replace the "Window.Location.replace" with "Window.open":

com.google.gwt.user.client.Window.open(BINARY_SERVLET_PATH + selectedNodePath + 
"/" +  "jcr:data" 
    + "&rmiUrl=" + rmiUrlTxt.getValue().toString() + 
    "&workSpace=" + workspaceTxt.getValue().toString() + "&mimeType=" + mimeType, 
"_blank", 
"toolbar=no,menubar=no,location=no,resizable=yes,scrollbars=yes,status=no"); 

What version of the product are you using? On what operating system?

1.1
XP SP3
Chrome 11 and FF3

Please provide any additional information below.

- Patch attached

Original issue reported on code.google.com by carl.pri...@gmail.com on 6 May 2011 at 12:28

Attachments:

GoogleCodeExporter commented 8 years ago
Patch applied as of revision #51. Thank you, Carl.

Original comment by chris.je...@priocept.com on 6 Jul 2011 at 5:15

GoogleCodeExporter commented 8 years ago

Original comment by chris.je...@priocept.com on 6 Jul 2011 at 5:16