search

christiangalsterer / stash-filehooks-plugin

An Atlassian Stash plugin to check on various file attributes, like size, name
Apache License 2.0
14 stars 27 forks source link

File Size detection seems not always to be working #42

Open AndreasStutz opened 6 years ago

AndreasStutz commented 6 years ago

We have a repo containing big (>> 1MB) .xml-files which are not detected by the setting of Max 1 MB. However cpp-files with size >> 1 MB are detected! Is there a Limitation on what the plgin detects? Is XML treted as binary and if so why isn't it detected nevertheless? Thanks for any support! Cheers, Andreas

christiangalsterer commented 6 years ago

Hi Andreas,

there is no special/different on file types, but it is just a simple regex expression. Please check how you have specified the size of the files. 1MB should be specified as 1048576. Please note that depending in your tool, e.g. explorer file size is also shown as 1MB although it is slightly larger/smaller. Please check the file size down to the byte level.

AndreasStutz commented 6 years ago

Hi Christian, thanks for your quick answer... However we checked and the file size settings are as you proposed and indeed some cpp-files are shown as being to large... However the missing ones of .txt and .xml-extension have a size of 23283442 and 19308664. The next biggest .cpp-File has size 10625893 and is actually reported... so the mystery remains... One important hint: The hook should have ringed alarm during an initial push fillling a Bitbucket repo with more than 3000 files contained... maybe a timing issue? Pls. help!

AndreasStutz commented 6 years ago

Tested with a new repo and only 85 files. Now the files too large (.txt and .XML) were all detected... However with 3000 files they weren't... so it is maybe really a timing issue?

AndreasStutz commented 6 years ago

Tested a second time with app. 2800 files -> same issue as before

christiangalsterer commented 6 years ago

With an older version there was a limitation that only the last 100 commits/files were checked. This is fixed with the latest version 3.1.1. for Bitbucket 5.2 and newer. I try to release a version also 4.x in the next 1-2 weeks.

AndreasStutz commented 6 years ago

Thanksalot!

AndreasStutz commented 6 years ago

Hi Christian, any update for the 4.x version of the plugin in sight? Thanks for any support!

Wawha commented 6 years ago

I have the same issue. On small repo, the hook works great. But on a large repo, the hook authorized to push big files. In my test, I used the same big file on the both repo, and just add one new commit with just this file new.

I found this basic hook, not configurable from UI, but which work great : https://github.com/amacneil/git-banish-large-files/blob/master/pre-receive.sh