christianhaitian / arkos

Another rockchip Operating System
MIT License
1.47k stars 83 forks source link

BUG: Diablo 1 no mouse control via right analog thumbstick #291

Closed Doom0325 closed 3 years ago

Doom0325 commented 3 years ago

I am on the latest version of ArkOS on an ANBERNIC RG351P. Mouse is locked in the left hand corner and cannot move.

christianhaitian commented 3 years ago

Looks like something with the new kernel caused the mouse to no longer function in Diablo 1. I can't seem to figure out what's caused the issue as it was the same issue previously experienced on the 64 bit version of Diablo 1. I've submitted the issue for review upstream in hopes they can help identify a resolve. https://github.com/diasurgical/devilutionX/issues/943

Rh0gii commented 3 years ago

I'm interpreting diasurgical/devilutionX#943 to suggest that the issue is with retroarch 64bit. So would we want to try to get this working on retroarch 32bit?

christianhaitian commented 3 years ago

No solution at this point.

southoz commented 3 years ago

Mouses!

The only time the mouse location values were updated was when an SDL_MOUSEMOTION event was being triggered and the right stick movement was definitely not triggering that event.

Update Mouse location within the HandleRightStickMotion routine has fixed the issue on the OGS.

https://github.com/southoz/devilutionX/commit/6a82fdee333bfd68105344914a629caae6e90f8e

christianhaitian commented 3 years ago

Mouses!

The only time the mouse location values were updated was when an SDL_MOUSEMOTION event was being triggered and the right stick movement was definitely not triggering that event.

Update Mouse location within the HandleRightStickMotion routine has fixed the issue on the OGS.

southoz/devilutionX@6a82fde

Nice. I'll check this out asap and if good, push an update to resolve!

christianhaitian commented 3 years ago

I've confirmed that this does fix the mouse issue. This fix will be included in the next update soon.

Rh0gii commented 3 years ago

is there a manual fix for those that are on say... Retro OZ on OGS...?

Rh0gii commented 3 years ago

Thanks to everyone that's never given up and found a fix by the way!

christianhaitian commented 3 years ago

If your comfortable with ssh or winscp, you can just take the executable out of the attached compressed file and put into the /home/ark/.config/devilution folder. RertroOZ may have a similar setup as well to allow this. You may have to set the permissions for the file to be executable so it can run. chmod 755 devilutionx. This can be done via winscp by simply right clicking on the file, then click on properties and set the permission for it to be executable there.

devilutionx.zip

Rh0gii commented 3 years ago

I'm familiar with ssh and winscp. I'll give it a shot. THANKS!

Rh0gii commented 3 years ago

jumped into my winscp. there is a ".config" folder in there, but no "devilution" folder within that. All well. I'll probably need help from the developer as to where the config folder is hiding for this port. thanks for the help anyway

southoz commented 3 years ago

The ArkOS folder is /home/ark/.config/devilution

ark@rg351p:~/.config/devilution$ l -a -l
total 2632
drwxrwxrwx  2 ark  ark     4096 Dec 16 05:35 ./
drwxrwxrwx 15 root root    4096 Apr 16 21:44 ../
-rwxrwxrwx  1 ark  ark  2684440 Dec 16 05:35 devilutionx*
ark@rg351p:~/.config/devilution$

RetroOZ has the executable in the /roms/ports/devilution

Rh0gii commented 3 years ago

Yeah... I haven't gotten to the point to work on my RG351 running ArkOS. At the moment, I was trying to get the mouse working for my OGS running RetroOZ. So... for RetroOZ... I just need to place the executable "devilutionx" file in the /roms/ports/devilution folder and execute it in an ssh session....? Or should I just stop messing with it before I hurt myself? (please pardon my n00bness, sometimes, when I try really hard, I know enough to be dangerous - XD )

southoz commented 3 years ago

RetroOZ 0.42 update includes the updated OGS binary. Keep messing, just backup your roms so you can reimage an SDCard or even better use a second card to mess around with. Breaking things is the first step to fixing them and if you need to ask questions or need help feel free to hit me up in the Odroid Forums. The more people that are tinkering the quicker issues are found and fixes can be made. You know your on track when you break things that bad have to open a serial console to your retro handheld :P

Rh0gii commented 3 years ago

WOOOO!!!, OK, I now have mouse-love working on my ArkOS powered RG351P! Thanks to you both for all of your work, help, and patients with me. As for my OGS running RetroOZ, yeah, I'm totally down to flashing 0.42 on a spare microsd and see what I can break!

Again, Cheers to you both! Rh0gii

On Fri, Apr 16, 2021 at 9:34 PM southoz @.***> wrote:

RetroOZ 0.42 update includes the updated OGS binary. Keep messing, just backup your roms so you can reimage an SDCard or even better use a second card to mess around with. Breaking things is the first step to fixing them and if you need to ask questions or need help feel free to hit me up in the Odroid Forums. The more people that are tinkering the quicker issues are found and fixes can be made. You know your on track when you break things that bad have to open a serial console to your retro handheld :P

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/christianhaitian/arkos/issues/291#issuecomment-821752655, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATKKEHYTLBAXZLQAM6MSL73TJDXSHANCNFSM4ZFKUR3A .

christianhaitian commented 3 years ago

Thanks for confirming that this resolved the issue. Big thanks to @southoz for the fix.

howdoicomputer commented 3 years ago

Super excited. I'm patiently waiting for my 351M and now I can use the final build of ArkOS because I'm super eager to relive Diablo before Resurrected comes out.