search

christianhelle / autofaker

Python library designed to minimize the setup/arrange phase of your unit tests
MIT License
6 stars 3 forks source link

tidy-ups #9

Closed marksmayo closed 1 year ago

marksmayo commented 1 year ago
marksmayo commented 1 year ago

Not sure what the sonar failure means?

christianhelle commented 1 year ago

First of all thanks for this contribution

I used PyCharm when writing this and used all the coding styles and formatting suggestions from PyCharm. If you used a tool to make all these changes then it would be great if you can include the configuration files of that tool so I can also start adapting it

christianhelle commented 1 year ago

Not sure what the sonar failure means?

This is because the SONAR_TOKEN GitHub workflow secret is inaccessible from your fork branch. If I made you a contributor to this repository, you can run the SonarCloud workflow.

I think I'll do that since you have already contributed quality stuff in the past

christianhelle commented 1 year ago

Not sure what the sonar failure means?

This is because the SONAR_TOKEN GitHub workflow secret is inaccessible from your fork branch. If I made you a contributor to this repository, you can run the SonarCloud workflow.

I think I'll do that since you have already contributed quality stuff in the past

According to Github:

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

@marksmayo I added you as a contributor to this repo so you should be able to create branches directly instead of forking.