Closed ikopytko closed 3 months ago
Attention: Patch coverage is 58.62069%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 83.70%. Comparing base (
c0ab9da
) to head (c33d517
). Report is 87 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/HttpGenerator.Core/HttpFileGenerator.cs | 58.62% | 8 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ikopytko I pulled the branch and tried it locally. The code looks good to me, It does what it should, and works fine
I tried generating files using all 3 available options (single file, per request, and per tag). When generating per tag, the output files use the tag value as it is for the filename, whereas the other options capitalize the first letter. Can we align it with the different options and capitalize the first letter?
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
@christianhelle that's great! Regarding file names - absolutely, already added the capitalization. I'm working mainly with asp.net controllers so I took it for granted.
This PR is related to feature request #97 Added support to generate file per operation tag. This implementation is not particularly efficient, as it will store partial result in
StringBuilder
for each file in memory, but it shouldn't cause much impact than building single file.OpenAPI allows to specify more than one tag per operation and Swagger UI will show the same request under multiple categories. But this implementation will look only for the first tag (this will be a controller name in case of default MVC Core configuration).