Closed osc-nseguin closed 4 months ago
@osc-nseguin Thanks for taking the time to improve this feature! Based on the screenshots, this is really cool!
@all-contributors please add @osc-nseguin for code
@christianhelle
I've put up a pull request to add @osc-nseguin! :tada:
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
@osc-nseguin The tests are unfortunately failing. Do you mind updating
XmlDocumentationGeneratorTests
? There are a couple of asserts there that check that the generated code contains the string<throws cref=\"ApiException\">
, and this is no longer valid with your changes
Sorry, I got a bit impatient and pushed the fixes myself 😄
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.34%. Comparing base (
0b3e451
) to head (0cac175
). Report is 30 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
<list type="table">
Both of these somewhat improve the rendering of the generated comments in Visual Studio and Rider.
Before (Rider):
After (Rider):
Before (Visual Studio):
After (Visual Studio):
The generated code is a little uglier due to the flat nested XML. One could avoid this by refactoring the string builder utility methods.