search

christianmalek / vuex-rest-api

A utility to simplify the use of REST APIs with Vuex
http://vuex-rest-api.org
MIT License
382 stars 48 forks source link

Optimistic update #71

Closed BorisTB closed 6 years ago

BorisTB commented 6 years ago
christianmalek commented 6 years ago

I've just reviewed your code. Seem's fine to me except one thing: originalState

What is this good for? It's just a reference to the current state.

BorisTB commented 6 years ago

Oh, sorry, it's dumb mistake.

It was supposed to help user undo changes from beforeRequest if request fails, but as I'm thinking about it now, user can handle these things without problem on his side. So I will remove originalState instead of fixing it