search

christianonoh / film-fussion

MIT License
1 stars 0 forks source link

set up your Kanban board #21

Open christianonoh opened 1 year ago

christianonoh commented 1 year ago

A team of two:

Link to project: https://github.com/christianonoh/group-capstone-js/projects/1

ABDULALI3468 commented 1 year ago

Changes Required 👍

Hi @christianonoh @muneeb3123 ,

Indeed you did an exceptional but still, there is room for changes to complete this project. 💯

Highlights

✅Created the KANBAN board. ☑️ Added cards and assignees. ✅ Grouyped cards for different students.

Required Changes ♻️

Please consider adding the assignees also to the tasks which are Group tasks means that you can assign them to all the members of the group to meet the project requirements.

Currently, it shows no assignees to group tasks.

image

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification.

  • This is My GitHub: GitHub followers
  • This is My Linkedin: Linkedin Badge 
  • This is My Twitter: Twitter Badge 

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mckent05 commented 1 year ago

Hi @christianonoh,

STATUS: APPROVED ✔️ ✔️

Your project is complete! There is nothing else to say other than... it's time to start your capstone 👍
Congratulations and well done! 🎉 approved

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.