Closed nokome closed 4 years ago
:wave: @christianp Sorry to bother you, but just prodding to see if you could review this PR please.
Hi, sorry, I'm incredibly busy at the moment, I should have time to look at this in a couple of weeks. I've never used CommonJS or UMD, so I'll need to read up on how they work.
Thanks for this - I've merged this PR and updated the usage instructions. I'll look at how to publish a new version to npm later.
Thank you.
@christianp Thanks for creating
asciimath2tex
:pray:. We are using it in https://github.com/stencila/encoda for our TeX codec.Encoda is a Node.js package, so we needed support for CommonJs modules. This PR adds that support, thereby closing https://github.com/christianp/asciimath2tex/issues/5. It also adds support for UMD, which means the note about browser support in the README can be removed.
Other notes:
if this is merged,
dist
should begit rm
d before publishing; see https://github.com/christianp/asciimath2tex/commit/168f4bd7514c9161c39269283fbaa1fc6e3118c4if this is merged, you might want to add some docs on using via a
<script>
tag pointing to the UMD bundle on unpkg.comI used
microbundle
instead ofbabel
mainly because it is a lot quicker to configure.