christianp / asciimath2tex

JavaScript library to convert AsciiMath to TeX
Apache License 2.0
68 stars 16 forks source link

Add support for CommonJs and UMD modules #7

Closed nokome closed 4 years ago

nokome commented 4 years ago

@christianp Thanks for creating asciimath2tex :pray:. We are using it in https://github.com/stencila/encoda for our TeX codec.

Encoda is a Node.js package, so we needed support for CommonJs modules. This PR adds that support, thereby closing https://github.com/christianp/asciimath2tex/issues/5. It also adds support for UMD, which means the note about browser support in the README can be removed.

Other notes:

nokome commented 4 years ago

:wave: @christianp Sorry to bother you, but just prodding to see if you could review this PR please.

christianp commented 4 years ago

Hi, sorry, I'm incredibly busy at the moment, I should have time to look at this in a couple of weeks. I've never used CommonJS or UMD, so I'll need to read up on how they work.

christianp commented 4 years ago

Thanks for this - I've merged this PR and updated the usage instructions. I'll look at how to publish a new version to npm later.

nokome commented 4 years ago

Thank you.