search

christianparobek / skeleSim

Null models, performance testing, and power estimation with population simulations
3 stars 6 forks source link

shinyFiles dependency #27

Closed christianparobek closed 8 years ago

christianparobek commented 8 years ago

Just pulled the new version of shiny server.R and ui.R. When I got to "Run App" it gives a new error - something to the effect of:

unknown function: shinyFilesButton()

I solved this by installing the shinyFiles package and loading it up with library(). But it seems like perhaps shinyFiles should now be a dependency upon install?

EricArcher commented 8 years ago

Definitely sounds like it. Good catch! Please add it to the dependency list in DESCRIPTION.

christianparobek commented 8 years ago

Interesting, I just checked the Depends list in the DESCRIPTION file and it's already in there. Maybe I did something wrong this morning? I started with a fresh github_install of skeleSim as well as updating my local repo with a pull. Could it be that it belongs in the Imports list instead?

EricArcher commented 8 years ago

Hmmm... the default for install_github seems to be to install dependencies listed in "Depends". Can you test by uninstalling other packages in Depends (like shiny) and reinstalling from GitHub to see if it actually does?

stranda commented 8 years ago

Has this one been resolved?

christianparobek commented 8 years ago

Yes, this was resolved.

christianparobek commented 8 years ago

This dependency has actually still been giving me problems off and on for a while. Today, I did a fresh install from github install_github("christianparobek/skeleSim") on three different computers: two Ubuntus and one Windows, and in each case I got this same error:

ERROR: could not find function "shinyFilesButton"

Two of these computers never had seen skeleSim before. Took a look at the DESCRIPTION file and shinyFiles isn't under the Depends section... odd. Trying to add that and will see if that fixes it.

christianparobek commented 8 years ago

This seems to fix it on all three computers.

christianparobek commented 8 years ago

Hope my fix doesn't mess anything else up!

EricArcher commented 8 years ago

I'd removed it from Depends and was looking to add it to Imports and add the appropriate @importFrom roxygen tags. Putting it back in Depends is fine for now. I'm still working on some build/check issues, but will come back to this later.