Closed christianparobek closed 8 years ago
Definitely sounds like it. Good catch! Please add it to the dependency list in DESCRIPTION.
Interesting, I just checked the Depends list in the DESCRIPTION file and it's already in there. Maybe I did something wrong this morning? I started with a fresh github_install
of skeleSim as well as updating my local repo with a pull
. Could it be that it belongs in the Imports list instead?
Hmmm... the default for install_github seems to be to install dependencies listed in "Depends". Can you test by uninstalling other packages in Depends (like shiny) and reinstalling from GitHub to see if it actually does?
Has this one been resolved?
Yes, this was resolved.
This dependency has actually still been giving me problems off and on for a while. Today, I did a fresh install from github install_github("christianparobek/skeleSim")
on three different computers: two Ubuntus and one Windows, and in each case I got this same error:
ERROR: could not find function "shinyFilesButton"
Two of these computers never had seen skeleSim
before. Took a look at the DESCRIPTION file and shinyFiles isn't under the Depends section... odd. Trying to add that and will see if that fixes it.
This seems to fix it on all three computers.
Hope my fix doesn't mess anything else up!
I'd removed it from Depends and was looking to add it to Imports and add the appropriate @importFrom roxygen tags. Putting it back in Depends is fine for now. I'm still working on some build/check issues, but will come back to this later.
Just pulled the new version of shiny
server.R
andui.R
. When I got to "Run App" it gives a new error - something to the effect of:I solved this by installing the
shinyFiles
package and loading it up withlibrary()
. But it seems like perhapsshinyFiles
should now be a dependency upon install?