search

christianrowlands / android-network-survey-rooted

A rooted version of the Network Survey Android App for advanced cellular survey
Apache License 2.0
27 stars 12 forks source link

To support Xiaomi 9T Android 11 #5

Closed HartonoTw closed 9 months ago

HartonoTw commented 9 months ago

Updated 'diag_revealer' and java code to support Xiaomi 9T Android 11

christianrowlands commented 9 months ago

Also, one other request for you. Can you write a unit test for the convertLteMibMessage method you added. An example of a unit test for those convert methods can be found here: https://github.com/christianrowlands/android-network-survey-rooted/blob/14f5d830aa94b4bf9a77bd1bc503d8030a3168bc/app/src/test/java/com/craxiom/networksurveyplus/QcdmTest.java#L247

christianrowlands commented 9 months ago

@HartonoTw , just checking in to see if you had a few spare cycles to knock out that unit test. It is pretty easy to write, and I would do it for you, but I don't have the LTE MIB message bytes to use in the test.

HartonoTw commented 9 months ago

@HartonoTw , just checking in to see if you had a few spare cycles to knock out that unit test. It is pretty easy to write, and I would do it for you, but I don't have the LTE MIB message bytes to use in the test.

already add unit test.

christianrowlands commented 9 months ago

Awesome, thanks @HartonoTw . Approved. You should be able to merge now.

HartonoTw commented 9 months ago

Sorry, first time use GitHub, I don't know how to merge it.

christianrowlands commented 9 months ago

No worries. I can merge it for you.

christianrowlands commented 9 months ago

Thanks again for working on this!

HartonoTw commented 9 months ago

Thanks again for working on this!

Thanks!