christianrowlands / android-network-survey

Cellular Survey Android App
https://www.networksurvey.app
Apache License 2.0
151 stars 27 forks source link

[Feature Request] MQTT Topic Customization #26

Closed mrepste closed 8 months ago

mrepste commented 9 months ago

Requesting a feature in the MQTT settings (and associated QR-code-based configuration) that would allow a user to prepend the NetworkSurvey MQTT topics with a provided string. For instance, if the user provides the string network_survey/, then the published topics become:

This would be useful for a few reasons:

christianrowlands commented 9 months ago

Yeah, this makes sense and is a great feature request.

I am wondering if the MQTT topic prefix should be set in the MQTT UI, or in the app settings. I could see an argument for both. If I place it in the app settings, then I would probably display something in the MQTT UI about the topic prefix if it is set, and maybe even provide a direct link to the settings so the user can easily change it.

What are your thoughts?

mrepste commented 9 months ago

I'd lean more towards keeping it within the MQTT configuration dialog, if only because it's such an MQTT-specific setting. If future versions of NetworkSurvey end up integrating other pub/sub-type protocols, the generalized app settings might get littered with all variations?

christianrowlands commented 9 months ago

Yeah, I think you are right. Keeping it with the MQTT settings will make it more obvious. I will see what I can work up.

christianrowlands commented 8 months ago

This feature was released in version 1.17! @mrepste , let me know if it does not meet your expectations.