5G-NSA vs LTE in Display

christianrowlands / android-network-survey

Cellular Survey Android App

https://www.networksurvey.app

Apache License 2.0

151 stars 27 forks source link

5G-NSA vs LTE in Display #39

Closed christianrowlands closed 4 months ago

christianrowlands commented 5 months ago

Bug reported by @pm4rcin

Describe the bug Another thing that is not present is that the app doesn't show 5G-NSA but it only shows LTE on Data Network. It could be done because an app Privacy Cell can show it.

Expected behavior The app should show 5G-NSA

Additional context This issue was originally brought up in this comment, but I moved it to its own issue.

christianrowlands commented 5 months ago

@pm4rcin I am not sure how to figure out if it is 5G-NSA or not. I am using the following Android API to get which data network is being used: https://developer.android.com/reference/android/telephony/TelephonyManager#getDataNetworkType()

Looking through all the possible return values at that link, I am not seeing one for 5G-NSA. I am guessing Privacy Cell is getting it from somewhere else, but I am not sure where. If you have any other thoughts I can try them out, but as of right now I don't see a way to get this information.

pm4rcin commented 5 months ago

Here you go, also you can even get if Carrier Aggregation is present. https://developer.android.com/reference/android/telephony/TelephonyDisplayInfo

christianrowlands commented 5 months ago

Oh, nice. I had not noticed that in the API docs before. Thanks for sending. I will get that added!

pm4rcin commented 5 months ago

Oh, nice. I had not noticed that in the API docs before. Thanks for sending. I will get that added!

FYI I have just Asked Perplexity AI and since it has access to internet it showed good results. :)

christianrowlands commented 5 months ago

I was able to add the override network to the display. The only part left is to add an info box describing what the "Override Network" is.

christianrowlands commented 5 months ago

@pm4rcin , And here is the description

Let me know if you have any suggestions for improving the layout or description.

pm4rcin commented 5 months ago

IMO it should be voice then data and then override layout because in other menus of android it's in this order. Also maybe use different color when override is present e.g. yellow or smth for font or even entire widget.

christianrowlands commented 4 months ago

Sorry for the slow response.

How about this @pm4rcin :

pm4rcin commented 4 months ago

No problem, we're not in hospital. ;) It looks great. Offtop: Would you change the appid in the CI by e.g. appending .beta so if someone wants to test artifacts in the future there's no need to reinstall?

christianrowlands commented 4 months ago

Yeah, that would make it easier to allow both to be installed at the same time. I will look into that.