DS402: Reset from fault does not work correctly.

christiansandberg / canopen

CANopen for Python

http://canopen.readthedocs.io/

MIT License

444 stars 196 forks source link

DS402: Reset from fault does not work correctly. #261

Open acolomb opened 3 years ago

acolomb commented 3 years ago

The BaseNode402.reset_from_fault() does not work as intended. It doesn't actually make sure the fault is cleared when it returns, but just unconditionally sets the rising edge on the Fault Reset bit after the actual check times out. This needs a rework, as the comment added in #260 explains.

friederschueler commented 4 months ago

Is this fixed? #260 is merged.