search

christiansandberg / canopen

CANopen for Python
http://canopen.readthedocs.io/
MIT License
446 stars 196 forks source link

Tests: make sure temporary files are pre-closed #507

Closed erlend-aasland closed 4 months ago

erlend-aasland commented 4 months ago

Windows fails with a permission error if the temporary file is already opened.

Fixes #501

erlend-aasland commented 4 months ago

@sveinse, can you see if this mitigates the problems you experienced?

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.78%. Comparing base (3aa509d) to head (fe6eb35).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/christiansandberg/canopen/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=3wUNWZVohh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg)](https://app.codecov.io/gh/christiansandberg/canopen/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg) ```diff @@ Coverage Diff @@ ## master #507 +/- ## ======================================= Coverage 68.78% 68.78% ======================================= Files 26 26 Lines 3117 3117 Branches 526 526 ======================================= Hits 2144 2144 Misses 835 835 Partials 138 138 ```
erlend-aasland commented 4 months ago

Thanks for the reviews!