christiansandberg / canopen

CANopen for Python
http://canopen.readthedocs.io/
MIT License
446 stars 196 forks source link

Tests: improve coverage of Network #515

Closed erlend-aasland closed 3 months ago

erlend-aasland commented 4 months ago

I'm not sure if I'm satisfied with this yet; I'll have another look tomorrow before marking it as ready for review.

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.17%. Comparing base (a196e1e) to head (d8d8d3c).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/christiansandberg/canopen/pull/515/graphs/tree.svg?width=650&height=150&src=pr&token=3wUNWZVohh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg)](https://app.codecov.io/gh/christiansandberg/canopen/pull/515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg) ```diff @@ Coverage Diff @@ ## master #515 +/- ## ========================================== + Coverage 68.86% 70.17% +1.31% ========================================== Files 26 26 Lines 3112 3112 Branches 526 526 ========================================== + Hits 2143 2184 +41 + Misses 831 800 -31 + Partials 138 128 -10 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/christiansandberg/canopen/pull/515/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg)
erlend-aasland commented 3 months ago

Thank you for the review!