search

christianselig / apollo-bugs

A public bug tracker for Apollo, an iOS Reddit app
228 stars 15 forks source link

Apollo via macOS has troubles opening the login page when the default browser is not Safari. #1619

Open HeySora opened 2 years ago

HeySora commented 2 years ago

I am using a MacBook Pro 14" 2021 (with a M1 Pro CPU), and I am using Apollo on it. My default browser is Google Chrome.

In the "Account" tab, when clicking Login, absolutely nothing happens. You can even cilck on it multiple times. No popup will appear. At this state, Safari was closed.

However, as soon as I clicked on Safari, it opened the login page popup (and attempting to quit it will instantly re-open one, because I clicked multiple times on the button).

However, as soon as I quitted all the Reddit pop-ups, the Apollo app showed a popup about cancelling the login operation. I quitted Safari, to go back to the initial state. I chose "I've had issues logging in", and this time it made the login page appear as expected on Google Chrome, without any issues.

In my opinion, the easiest way to fix this issue is simply to default to that option, when running under macOS. (I have no Objective-C experience but apparently you can simply use [NSProcessInfo processInfo].isiOSAppOnMac.)

iOS version: macOS 12.2 (21D49) Apollo version: Apollo 1.12.2 iOS device: MacBookPro18,3 (I'm sure it is reported as an iPadX,X but I do not remember where to find this information) Jailbroken: SIP is enabled, macOS's Security is on the highest level. Reproducible: Every time.

notnotjake commented 2 years ago

Similar issue here. I have my default browser set to Safari and in Apollo, do not get a login pop-up. However, a few days later I opened Chrome and I got every pop-up from my attempts to login. If I try to login while Chrome is open, it doesn't make a difference. If however I click the "I've had issues logging in" then it opens in Safari and works.