search

christianvuerings / jquery-lifestream

Show a stream of your online activity with jQuery
https://christianvuerings.github.io/jquery-lifestream/
MIT License
760 stars 133 forks source link

using tweet url instead of user url #168

Closed songgao closed 10 years ago

songgao commented 10 years ago

so that url of each tweet can bind to each li in ul

christianvuerings commented 10 years ago

@songgao this changes the behavior with how it previously works. Is there no way we can use the complete_url here?

songgao commented 10 years ago

@christianv Good point. It seems data fields are appended here: https://github.com/christianv/jquery-lifestream/blob/master/src/core.js#L91 So I think we'll have to make core.js aware of more fields in order to use complete_url (which also require some changes in twitter.js). Maybe add a custom object for context in core.js?

Here's what I was thinking: item.data('url') is per li instead of per service. I think it makes more sense to make URLs scope to each item (e.g. twitter status url) instead of the entire service (e.g. twitter user page). But if the url field is used for other purposes then it's a different story...