search

christianwach / civicrm-admin-utilities

CiviCRM Admin Utilities is a WordPress plugin that modifies and enhances CiviCRM's appearance and behaviour in single site and multisite WordPress installs.
https://wordpress.org/plugins/civicrm-admin-utilities/
GNU General Public License v2.0
20 stars 10 forks source link

Custom Stylesheet in CiviCRM Admin setting not respected - still loads in admin #30

Closed andyburnsco closed 2 years ago

andyburnsco commented 2 years ago

After many hours of debugging I'm at a loss on this one. I've deactivated all plugins minus CiviCRM 5.45.2 and CAU 0.9.1 and used default 2020 theme. WP 5.7.5 multisite.

The CiviCRM custom CSS file is loading in the admin while we have the setting checked in CAU to prevent this:

image

Out of curiosity I've tested the 3 other CiviCRM stylesheet settings to see if they still take effect when checked and they do image

The 2 settings I check are:

IIRC in my upgrade steps this did not occur on 5.40.4 but started occurring on 5.41.2.

Thoughts? Will fund further investigation of issue and fix.

christianwach commented 2 years ago

@andyburnsco Thanks for raising the issue. You're right - it seems that CiviCRM has changed the way in which this works. I'll look into a fix for more recent versions of CiviCRM.

christianwach commented 2 years ago

Ah, here we go: change happened in https://github.com/civicrm/civicrm-core/pull/20278

christianwach commented 2 years ago

@andyburnsco Should be fixed in 9e0214d9cc31d9bfca13dfa7d604ad5273fb982b

andyburnsco commented 2 years ago

I've tested https://github.com/christianwach/civicrm-admin-utilities/commit/9e0214d9cc31d9bfca13dfa7d604ad5273fb982b and it works. Thank you!