search

christianwach / civicrm-admin-utilities

CiviCRM Admin Utilities is a WordPress plugin that modifies and enhances CiviCRM's appearance and behaviour in single site and multisite WordPress installs.
https://wordpress.org/plugins/civicrm-admin-utilities/
GNU General Public License v2.0
20 stars 10 forks source link

PHP8 deprecation warnings #34

Closed braders closed 2 years ago

braders commented 2 years ago

I'm seeing lots of warnings of this style:

[21-Sep-2022 12:50:02 UTC] PHP Deprecated:  Required parameter $metabox follows optional parameter $unused in /var/www/html/[redacted]/web/app/plugins/civicrm-admin-utilities/includes/civicrm-admin-utilities-multidomain.php on line 526
[21-Sep-2022 12:50:02 UTC] PHP Deprecated:  Required parameter $metabox follows optional parameter $unused in /var/www/html/[redacted]/web/app/plugins/civicrm-admin-utilities/includes/civicrm-admin-utilities-multidomain.php on line 543
[21-Sep-2022 12:50:02 UTC] PHP Deprecated:  Required parameter $metabox follows optional parameter $unused in /var/www/html/[redacted]/web/app/plugins/civicrm-admin-utilities/includes/civicrm-admin-utilities-multidomain.php on line 827
[21-Sep-2022 12:50:02 UTC] PHP Deprecated:  Required parameter $metabox follows optional parameter $unused in /var/www/html/[redacted]/web/app/plugins/civicrm-admin-utilities/includes/civicrm-admin-utilities-multidomain.php on line 844

The plugin is still working, so fixing this will just remove some log noise. Seems to affect any servers running PHP8+

christianwach commented 2 years ago

Thanks @braders I'll attend to this in due course. Unless you beat me to it ;-)

christianwach commented 2 years ago

@braders Should be fixed in d0620ed49718b5629e217a9f19e5e9248dabfbc8

braders commented 2 years ago

@christianwach We've deployed this change to our production environment and have spotted no issues and the issue is no longer occurring. Thanks.

christianwach commented 2 years ago

Thanks