christianwach / civicrm-admin-utilities

CiviCRM Admin Utilities is a WordPress plugin that modifies and enhances CiviCRM's appearance and behaviour in single site and multisite WordPress installs.
https://wordpress.org/plugins/civicrm-admin-utilities/
GNU General Public License v2.0
20 stars 10 forks source link

CiviCRM Admin Utils, will reset the Backend Theme to "Automatic" if Radstock is NOT selected which causes the previous selected theme to be unset #38

Closed agileware-justin closed 7 months ago

agileware-justin commented 7 months ago

CiviCRM Admin Utils, will reset the Backend Theme to "Automatic" if "Radstock" theme is NOT selected which causes the previously selected theme to be unset. Which is a bummer when using "The Island" theme as there is a noticeable difference.

Sorry, do not have a PR or fix - just reporting.

Agileware Ref: CIVICRM-2240

christianwach commented 7 months ago

@agileware-justin Thanks for the report. Could you give me steps to reproduce? I'm not quite clear when the "is NOT selected" happens 🤔

agileware-justin commented 7 months ago

I think these were the steps:

  1. Install Island Theme, CiviCRM extension
  2. This changes the CiviCRM backend theme to Island Theme. Check that this is the case and if not, set the backend theme to Island Theme
  3. Go to the CiviCRM Admin Utils page, check that Radstock theme is not enabled. Click Update.
  4. Check the CiviCRM backend theme again, now set to Automatic. Should remain Island Theme.
christianwach commented 7 months ago

Thanks @agileware-justin I'll look into it.

christianwach commented 7 months ago

Fixed via 22749fdb4fd4b834ef943970ad7d9cf8821903ec.

The Island Theme isn 't playing nicely though - it still injects its wordpress.css file in the footer even when not selected. Grr.

agileware-justin commented 7 months ago

Thanks very much @christianwach

christianwach commented 7 months ago

FYI @agileware-justin I also opened an MR on The Island to fix its bad behaviour when the Extension is enabled but it's not the the active back-end theme.

agileware-justin commented 7 months ago

Thanks again!