search

christianwach / civicrm-admin-utilities

CiviCRM Admin Utilities is a WordPress plugin that modifies and enhances CiviCRM's appearance and behaviour in single site and multisite WordPress installs.
https://wordpress.org/plugins/civicrm-admin-utilities/
GNU General Public License v2.0
20 stars 10 forks source link

Dual Calendar Symbols #7

Closed Nevadamtb closed 5 years ago

Nevadamtb commented 5 years ago

Not sure this is a bug but in the Civicrm date pickers I get both the cal.gif and the fa icons. Love the new style additions. Thanks!

christianwach commented 5 years ago

@Nevadamtb Which version of CiviCRM are you using?

Nevadamtb commented 5 years ago

5.7.2

Nevadamtb commented 5 years ago

It was a plugin. I had installed Mosaico (testing) which needs Shoreditch.

christianwach commented 5 years ago

Ah, I see, the cal.gif file was removed in this PR

Nevadamtb commented 5 years ago

So now I just have the cal.gif not the fa-calendar.

christianwach commented 5 years ago

Oh dear, this looks like it's going to be a bit complicated... this plugin may need a separate stylesheet for pre-5.7.2 and post-5.7.2. FWIW, I can see a similarly confusing issue with today's release of CiviCRM 5.8. For now, I'm just going to remove the cal.gif icon for the time being - it's fugly and doesn't really help anyone.

Annoyingly, the new CiviCRM template now contains the glyph, but for me, it's broken. Moreover, the ::placeholder pseudo-element doesn't support display: none; so I can't hide it easily either. Time to open an issue in core methinks.

christianwach commented 5 years ago

@Nevadamtb Latest commit to this repo removes the icon in pre-5.8 and supports FontAwesome when it's available. Better than having both and better than having an unidentifiable square glyph.

Thanks for reporting this.