search

christianwach / civicrm-wp-member-sync

CiviCRM WordPress Member Sync plugin keeps a WordPress user in sync with a CiviCRM membership by granting either a role or capabilities to a WordPress user who has that membership.
https://wordpress.org/plugins/civicrm-wp-member-sync/
GNU General Public License v2.0
17 stars 10 forks source link

Add Association Rule page not loading #43

Closed dmpinder closed 1 year ago

dmpinder commented 1 year ago

When trying to load the "Add Association Rule" page (page=civi_wp_member_sync_rules), the page is coming up blank with no content.

I'm not sure if I've missed a configuration somewhere, but I noticed that if I change $mode to have a default value of add on this line (https://github.com/christianwach/civicrm-wp-member-sync/blob/master/includes/civi-wp-ms-admin.php#L1115) then the page loads just fine.

Can you let me know if I'm doing something wrong?

Thanks!

dmpinder commented 1 year ago

Update: rolling back to version 0.5.2 of the plugin works, so I suspect the issue is somewhere within the commit https://github.com/christianwach/civicrm-wp-member-sync/commit/305b9940b6c3c73b5afc6eb5e27240df3a209795

christianwach commented 1 year ago

@dmpinder Ouch! Thanks for the report - I'll have a look at this today... and yes, I suspect you're right about the commit that introduce the problem.

christianwach commented 1 year ago

@dmpinder I think a3d6a418acbacb2f58845a4cb32203fa27458b73 should fix things. I'll push to the WordPress Plugin Directory shortly.

dmpinder commented 1 year ago

@christianwach I can verify the fix, thanks for patching so promptly! 🙌

christianwach commented 1 year ago

Thanks for alerting me to this and for testing @dmpinder - new version is now on WordPress Plugin Directory.