christianwach / civicrm-wp-member-sync

CiviCRM WordPress Member Sync plugin keeps a WordPress user in sync with a CiviCRM membership by granting either a role or capabilities to a WordPress user who has that membership.
https://wordpress.org/plugins/civicrm-wp-member-sync/
GNU General Public License v2.0
17 stars 10 forks source link

apply new username filter for dry run, too. #45

Closed composerjk closed 1 year ago

composerjk commented 1 year ago

Allows dry run option for Manual Synchronization to show the username that might be used when the civi_wp_member_sync_new_username filter is defined. Addresses #44.

christianwach commented 1 year ago

@composerjk Thanks for this - good catch. Just one thing - could you put the filter after the call to unique_username() to mirror the order when running sync for real?

composerjk commented 1 year ago

@christianwach Done. For the initial implementation on a new install, I had just done the simplest change.

christianwach commented 1 year ago

Thanks @composerjk