search

christinaa / rpi-open-firmware

Open source VPU side bootloader for Raspberry Pi.
Other
1.13k stars 111 forks source link

Map peripheral addresses conditionally #33

Open alyssarosenzweig opened 7 years ago

alyssarosenzweig commented 7 years ago

See #31

alyssarosenzweig commented 7 years ago

87bf3214eb1acf423061c08b83977208fc41dff7 should solve this at compile-time, which I'd argue is the correct solution, seeing as other parts of the blob are version-dependent. Adding that much indirection when different builds are okay seems like a waste of human as well as machine cycles.

christinaa commented 7 years ago

I think it's a bad solution. We need to move as much code as we can into the VPU drivers and then just keep the ARM chainloader to a minimum and use a global to keep track of the MMIO base instead of hardcoding it. What we definitely don't want is using a static MMIO base depending on the target.