search

christocracy / shopify-api-limits

A simple Gem for reading shopify API call limits
17 stars 15 forks source link

fixed :limit => false. fixed broken spec. isolated ActiveResource::Base to ShopifyAPI::Base #5

Closed michaelglass closed 10 years ago

michaelglass commented 13 years ago

sorry about the spam, found a bug in my patch (!!).

but now it really does work.

the :limit => false code was slightly in the wrong place and was not working. When I was trying to get all 251 orders I instead received 2x the first 250 orders.

there was a typo in one of the specs. fixed.

Base extended ActiveResource but really only needed to extend ShopifyAPI::Base so I patched that too.

christocracy commented 13 years ago

Have you looked at the tests? Feel free to add/modify.

Snet form my iPhone

On Aug 31, 2011, at 6:49 PM, michaelglassreply@reply.github.com wrote:

sorry about the spam, found a bug in my patch (!!).

but now it really does work.

the :limit => false code was slightly in the wrong place and was not working. When I was trying to get all 251 orders I instead received 2x the first 250 orders.

there was a typo in one of the specs. fixed.

Base extended ActiveResource but really only needed to extend ShopifyAPI::Base so I patched that too.

Reply to this email directly or view it on GitHub: https://github.com/christocracy/shopify-api-limits/pull/5

michaelglass commented 10 years ago

looks dead to me. feel free to reopen if you want.