Fixed Info.plist generation in Client/info.plist to properly ask for …

[zalez]

Hi Christof,

today I spent some time with the code and managed to get microphone access working again. As a bonus, I added a simple icon to the macOS X app. It's not the prettiest one, but a start.

In more detail:

• Sorted keys in Client/info.plist to the same sequence as before April 20th, 2021.
• Added an empty line to separate the original, known to work keys from the additional keys post-April-20th.
• Set MACOSX_BUNDLE_GUI_IDENTIFIER to com.christofmuc.jammernetz in Client/ CMakeLists.txt. This sounds more logical to me.
• Added a JammerNetz icon. Not pretty, but a start. Feel free to improve it.
• Set MACOSX_BUNDLE_ICON_FILE to JammerNetzIcon.icns
• Set MACOSX_BUNDLE_SIGNATURE in CMakeLists.txt and the corresponding CFBundleSignature key in info.plist to say "jmrn". This is not a cryptographic signature, but rather another (historic) 4-letter Application identifier. jmrn sounded like a logical choice here.
• Got rid of NSSupportsAutomaticGraphicsSwitching due to https:// stackoverflow.com/questions/12445561/nssupportsautomaticgraphicsswitching-support
• Uncommented icon related stuff in CMakeLists.txt. Didn't quite work yet, so I used the second answer from https://stackoverflow.com/questions/22745728/cmake-set-icon-for-a-mac-os-x-app
• Some miscellaneous cosmetic fixes to CMakeLists.txt, mostly spaces/tabs related stuff.

Hope this works for you and happy jamming!

Constantin

[zalez]

Hi Christof,

I now got the relocatable binary working:

• The issue was that the JammerNetz Client app did not find the TBB library due to a missing @rpath.
• Using otool -l (See: https://stackoverflow.com/questions/12521802/print-rpath-of-an-executable-on-macos), I was able to see that the binary did not have any rpath set.
• This article talks about how to add a custom rpath to a binary with CMake for a Mac: https://izziswift.com/how-do-you-add-an-rpath-to-an-executable-in-cmake-on-build-not-install-on-osx/
• So I added a custom command to the Client's CMakeLists.txt that adds the right rpath to the Mac binary and now it works: I can generate a working .dmg file with --target package, open it and either double-click on the app or drag it to the Applications folder to install. The app works fine in both cases by simply double-clicking it.

Hope this helps, Constantin