search

christofmuc / JammerNetz

OpenSource internet jam sessions, aka Networked Music Performance software.
GNU Affero General Public License v3.0
51 stars 13 forks source link

SERVER: Port 0 is accepted when no "=" sign is used in specifying command line param #27

Open reneknuvers opened 3 years ago

reneknuvers commented 3 years ago

When starting the linux server compiled from the latest GitHub sources, and started with JammerNetzServer -k JammerNetzSecret_202105140952.bin --port 22125 the output shows Server listening on port 0

Tried different port numbers, also didn't work.

I can't connect to the server, so using the --port switch may be breaking the server altogether?

Using Ubuntu 20.04 and the compilation instructions in the Github readme.

reneknuvers commented 3 years ago

Ah: found the issue here. The command line should read --port=22125. When the = is committed, no error is thrown and the server binds to port 0, which will never work.

christofmuc commented 3 years ago

@reneknuvers Thanks! Yes, this is based on the weird JUCE command line parsing, which is not really gnu compatible. But it should abort with an error as Port 0 is not a valid number, I'll add some error checking!