this pull request is for adding support for a minimum audio buffer size.
Some audio devices (e.g. on Macs) may report very low buffer sizes (e.g. 4 bytes). This may introduce instabilities when interacting with other audio devices or the overall JammerNetz audio buffer. This pull request specifies a minimum required audio buffer size in Client/Source/ApplicationState.h of 128 Bytes, then enforces this minimum in Client/Source/AudioService.cpp.
The change has been successfully tested on a MacBook Pro M1 running macOS Big Sur Version 11.6 and instead of previously reporting 4 Bytes buffer size when opening the audio device, it now report 128 Bytes.
christofmuc
commented
1 month ago
Hi,
this pull request is for adding support for a minimum audio buffer size.
Some audio devices (e.g. on Macs) may report very low buffer sizes (e.g. 4 bytes). This may introduce instabilities when interacting with other audio devices or the overall JammerNetz audio buffer. This pull request specifies a minimum required audio buffer size in Client/Source/ApplicationState.h of 128 Bytes, then enforces this minimum in Client/Source/AudioService.cpp.
The change has been successfully tested on a MacBook Pro M1 running macOS Big Sur Version 11.6 and instead of previously reporting 4 Bytes buffer size when opening the audio device, it now report 128 Bytes.
Hope this helps, Constantin