christofmuc / KnobKraft-orm

The KnobKraft Orm - The free modern cross-platform MIDI Sysex Librarian
GNU Affero General Public License v3.0
204 stars 27 forks source link

Versioning / Version check of adaptations #123

Open markusschloesser opened 2 years ago

markusschloesser commented 2 years ago

When I installed and ran the new version from today, KK greeted me with "detected user adaptation, overriding inbuilt one" (or similar), which was the one for the sq80 which I downloaded from the discussion here on GH. Now the inbuilt one would have been the newer one, that's why I deleted the user adaptation, so how about:

  1. versioning for adaptations
  2. notify user of there's a newer one inbuilt
Mostelin commented 2 years ago

Even though I knew what was happening, when I saw that message I thought that some users might interpret it as an error of some kind, so I agree that perhaps there is a better way to handle this.

Incidentally, the new version 0.9 merely translates names in a nicer way, and has some clean-up work in its comments.

christofmuc commented 2 years ago

@markusschloesser Agree, but this is a can of worms, really. I try to do the versioning for user-contributed adaptations, because you should really use git (hub) for this. And the versioning is not a straight line of versions, you might have started making changes on an earlier version, then a new version gets build in... this is essentially a fork requiring a 3-way merge instead of just being "newer". Scratching my head here.

markusschloesser commented 2 years ago

mmh, maybe keep it simple in the beginning and use the DATE as the indicator?

christofmuc commented 2 years ago

@markusschloesser So like "this version of KnobKraft has an adaptation that is newer than your local version" as a warning?

markusschloesser commented 2 years ago

Yes, exactly that.

Happy new year to you! 😊

christofmuc commented 2 years ago

@markusschloesser Happy new year :-)

Andy2No commented 2 years ago

@christofmuc @markusschloesser @Mostelin Happy new year! :)

christofmuc commented 2 years ago

@Andy2No Hihi, happy new year as well!