christofmuc / KnobKraft-orm

The KnobKraft Orm - The free modern cross-platform MIDI Sysex Librarian
GNU Affero General Public License v3.0
200 stars 25 forks source link

MS2000/Microkorg fix #239

Closed BM-01 closed 1 year ago

BM-01 commented 1 year ago

Hey thanks for making such a cool app!

I'm new to this so apologies if this isn't the correct approach, but the MS2000 adaptation didn't work with my microkorg. The issue appears to be that the hardware ID for the microkorg was incorrect. I fixed it by adding 0x11 to line 72 in the MS200 adaptation file. Maybe it's worth having a separate adaptation for the microkorg?

Thanks again!

christofmuc commented 1 year ago

Thanks, that's cool! If the models are completely compatible and the only problem was the detection, your fix is probably all it needs. Sometimes we need to store the ID detected and use it later when composing the edit buffers for the specific synth, then we'd add a global variable to the module. But it seems the microkorg accepts original dumps from the MS2000?

I'll take your fix into the next release!

BM-01 commented 1 year ago

Hey Christof thanks for the reply!

Yep microkorg can read ms2000 patches and vice-versa.

Can't wait for the ability to send banks to the synth! ;)

Thanks for creating this!

Brad

On Fri, 10 Mar 2023, 10:31 Christof, @.***> wrote:

Thanks, that's cool! If the models are completely compatible and the only problem was the detection, your fix is probably all it needs. Sometimes we need to store the ID detected and use it later when composing the edit buffers for the specific synth, then we'd add a global variable to the module. But it seems the microkorg accepts original dumps from the MS2000?

I'll take your fix into the next release!

— Reply to this email directly, view it on GitHub https://github.com/christofmuc/KnobKraft-orm/issues/239#issuecomment-1462983476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRCFK76EDYLCSAZXD7WELDW3JR6FANCNFSM6AAAAAAVIK6EZA . You are receiving this because you authored the thread.Message ID: @.***>

christofmuc commented 1 year ago

Released with 2.0.3 today.