Consistency: Wording and naming style

[bboc]

There is a bit of confusion going on with the adapt(at)ion that should be fixed: is it adaption, or adaptation? I guess it's the latter, but then the directory for adaptations should be renamed.

Also there should be a consistent style for the names of the adaptations, at the moment there's spaces and underscores, and combined with variations of CamelCase. Some examples:

• DSI Prophet 08.py
• DSI_Mopho_X4.py
• Ensoniqesq1.py
• KorgMS2000.py
• Matrix1000
• PioneerToraiz-AS1
• Roland JX-8P.py
• Roland_JV1080.py

Since we're talking Python modules, I suggest following PEP8.

• dsi_prophent_08.py
• dsi_mopho_x4.py
• ensoniq_esq_1.py
• korg_ms2000.py
• oberheim_matrix_1000
• pioneer_toraiz_as_1.py
• roland_jx_8p.py
• roland_jv_1080.py

Or, you prefer to have the correct names, at least consistently use spaces (and not underscores) between words, and use capitalization and hyphens they way the manufacturer named the device (which can be seen on the device or at in the manual):

• DSI Prophet 08.py
• DSI Mopho x4.py
• Ensoniq ESQ-1.py
• Korg MS2000.py
• Oberheim Matrix-1000.py
• Pioneer Toraiz AS-1.py
• Roland JX-8P.py
• Roland JV-1080.py

[christofmuc]

Completely correct. The confusion stems from the fact that first I called it adaptions, and then later learned adaptations would have been correct. I renamed it everywhere except in the directory name fearing update or upgrade problems. We probably should fix that.

And yes, the Python file names were originally not visible, so I used the nice display name, but when they became external I missed the opportunity to cleanup, and now any update is in danger of screwing up big time in case the installer doesn't remove the old files correctly. Admittedly, I just didn't dare to touch them.

I'll keep this open, maybe I'll get an idea how to do this in a safe way.

[bboc]

@christofmuc I think renaming the adaptation directory and renaming the files might go together well. When a new version of the Orm encounters the old directory, it simply deletes it, and installs the new directory. The new directory will contain the new names. Or am I missing something?

[christofmuc]

I renamed the wrong adaptions to adaptations now. The good news is that this never reached the target computer, because the installer always create an adaptation directory. The bad news is that we then need to rename each file individually to make sure the prior version is removed by the installer one by one.