Upgrade from Python 3.8 to 3.12

christofmuc / KnobKraft-orm

The KnobKraft Orm - The free modern cross-platform MIDI Sysex Librarian

GNU Affero General Public License v3.0

184 stars 23 forks source link

Upgrade from Python 3.8 to 3.12 #282

Closed mslinn closed 2 months ago

mslinn commented 8 months ago

I noticed that on Windows, %LOCALAPPDATA%\Programs\KnobKraftOrm\python38.zip contains Python 3.8. That is a 4-year-old release. Python 3.10 sped up Python quite a bit. Perhaps it might be worth upgrading to Python 3.12.

christofmuc commented 8 months ago

This is true! It is always a trade off - we have users who are still on Windows 7, and for those Python 3.8 is the latest Python version that works :-(

What we could do is to duplicate the build pipeline and build both versions, one for modern computers and one for Windows 7.

markusschloesser commented 8 months ago

If Microsoft hasn't supported it for 10 years or so and python does not support it anymore, question is why do you have to support it? 😉 Nobody should be running it anywhere any longer (security). Maybe sounds weird but sometimes progress demands cutting off old stuff. Especially as windows (10/11) still has excellent backwards compatibility. Maybe declare the current release 2.08 the last one for win7 and then move on?

christofmuc commented 8 months ago

I was just trying to be nice, we had long discussion in #141 about this. But yes, I agree the latest build should probably be on an up to date Python. I don't expect any performance difference, but it will be better to be on an up to date version anyway!

christofmuc commented 8 months ago

Actually, we'll be running into all kinds of bad situations when creating a second build - we have auto updates, and uses will be nudged to update to a version that will no longer work on their machine.

Maybe we should provide a way for the Windows version to use an externally supplied Python, just like the Mac version does. So if the supplied Python doesn't work you can switch back to one that you have installed elsewhere on the computer?

christofmuc commented 3 months ago

Current research:

Windows update from Python 3.8 to Python 3.12 is straightforward, as this is embedded. We deny users of Windows 7 the use of KnobKraft then - I can build Andy a private version in case it is still needed.
MacOS - that's more complicated, as I usually recommend people to use homebrew, but they change the version of Python quite frequently so by now people need to go to python.org and download and installl the "correct one". Those would need to change when we update to 3.12, so every user has to manually update the Python version, I don't like that, but Mac is on 3.10 already and we can probably keep them there for a while.
Linux - we still build old executable on Ubuntu 20.04 LTS, which is supported until April 2025. But that has only Python 3.8. We can update the build machine to 22.04 which comes with 3.10.

mslinn commented 3 months ago

Emphasize future needs, not current needs, when making decisions for the future. Your decision will become increasingly correct as time passes.

Andy2No commented 3 months ago

I'm fine with just sticking with the final Win7 compatible version. Hopefully any adaptation I write will still be useful to someone else.

FWIW, I do now have a machine with Win 10 on it, but it annoys the hell out of me, so I rarely use it for much. Security is my concern, not Microsoft's.

christofmuc commented 2 months ago

Released with 2.3.0. No Windows 7 anymore, if you need a private build, I can make you one!