christofmuc
commented
6 months ago @fractalf Glad you like it!
Let me see if I can help.
The MS2000 detection reply is correct, and should be picked up, Maybe it is a timing issue and the synth is too slow? Look at the timestamps and see if the Orm has already given up on the reply on that channel and has moved on? Can you show the complete MIDI log? Also, you could try to increase the message delays which are at 200 ms for auto detection.
The Virus implementation is as of now in C++ and not Python, so that's ok. The detect reply is also correct and should be recognized. So this is weird as well. Sometimes having a device that causes MIDI loops can screw up the auto detection. Can you try enabling only a single synth in the setup and turning off all hardware devices except the one synth you are trying to detect?
Awesome stuff with the docker file!
Yes, the files are very Unlinuxy. The code from JUCE is trying to be portable. let's have a look:
/** The folder in which applications store their persistent user-specific settings.
On Windows, this might be "\Documents and Settings\username\Application Data".
On the Mac, it might be "~/Library". If you're going to store your settings in here,
always create your own sub-folder to put them in, to avoid making a mess.
On GNU/Linux it is "~/.config".
*/
userApplicationDataDirectory,
/** A place to put documents which are shared by all users of the machine.
On Windows this may be somewhere like "C:\Users\Public\Documents", on OSX it
will be something like "/Users/Shared". Other OSes may have no such concept
though, so be careful.
*/
commonDocumentsDirectory,So the Linux ~/Documents is not implemented by the Library. That's probably why I used the userHomeDirectory instead.
I am not really sure why it is creating a ~/KnobKraftOrm directory. What's in there?
fractalf
Hi there!
First, thank you for your incredible work on this piece of software :) I came across this while searching for some random MIDI stuff...
Here are some feedback, excuse the length of the issue, I still hope you find it interesting.
Thank you!
Korg MS2000R
I have a Korg MS2000R and thought I might get lucky since I saw the support for MS2000, but it doesn't seem to find it..
When doing the
[Auto-Detect]and listening to MIDI from my synth I can see the response when it is probed:Then comparing to the code for MS2000 they seem pretty much the same to me, so I'm not sure why this doesn't work.
There is some part in the comment there that says
0g, but last I checked that's not a hex, so maybe a typo?https://github.com/christofmuc/KnobKraft-orm/blob/cb1ae3fe4f2ca08eb0ff18aeeb198a43f4352044/adaptations/KorgMS2000.py#L48-L67
The MS2000R is pretty much identical to the MS2000, so I see no reason why this shouldn't work, do you?
I'm happy to help you debug this to get it working! :)
Access Virus A
I couldn't see this on the list and when I tried the closest that is on the list (Virus B) it doesn't find it.
I listend to the MIDI device where my Virus A is connected when the program does the probe, and this is what it answers
I didn't find a python file for the Access stuff, but found some C++ stuff under
synths/, but that's a bit above my comprehention :)Arch linux builds (docker setup)
I'm on EndeavourOS (based on Arch Linux) and the binary you provide from your build pipeline didn't work for me due to some error on libicuuc.so
..so I made a docker setup to build it for Arch Linux and thought I'd share it here if you or anyone else is interested.
docker-compose.ymlDockerfile-archRun it like this and copy the binaries to your local
~/binFiles on /home/user
After running the binary I see these folders created
The first is ofc totally fine, but creating those other folders on the root of the home folder is pretty bad practice on a Linux system. You should consider moving them to
~/Documents/KnobKraftor something like that.