christolliday / limn

Experimental cross platform GUI library
Other
404 stars 19 forks source link

Fixes for clippy, added documentation effort #20

Closed fschutt closed 6 years ago

fschutt commented 6 years ago

This branch adds missing information, as well as clippy lints. This fixes roughly 200 clippy lints and prevents lots of bugs, ranging from floating-point errors to performance issues (lots of types could implement Copy and Default, but didn't).

So that's for the clippy lints. But please, DOCUMENT stuff. I can't guess what functions are supposed to do in a bigger picture, which is horrible for maintenance. One comment per function at least, please.

Notable changes:

christolliday commented 6 years ago

Thanks for this, looks mostly good aside from the comments above, yeah documentation is a high priority for me now that people are actually looking at this project. Currently working on a documentation branch I'll merge sometime after this.