Adapt is_vim so that it works with .vim-wrapped on NixOS

christoomey / vim-tmux-navigator

Seamless navigation between tmux panes and vim splits

MIT License

5.07k stars 319 forks source link

Adapt is_vim so that it works with .vim-wrapped on NixOS #368

Open kranich opened 7 months ago

kranich commented 7 months ago

vim on NixOS presents itself as .vim-wrapped which was not covered in the regexp of is_vim.

Fixes #264.

Given the increasing adoption of NixOS as compared to in 2017, would you please reconsider your statement at https://github.com/christoomey/vim-tmux-navigator/pull/171#issuecomment-315064855 and be so kind as to accept this merge request?

christoomey commented 7 months ago

Hey @kranich -- happy to make the change here. I appreciate the notes and thinking. Would you mind updating the README to mirror the changes you made in the TPM file? Ideally those two would match each other.

kranich commented 7 months ago

Thank you! I have updated is_vim in README.md section "Add a snippet" in 61b278e.

I will also prepare pull requests on the NixOS side of things to upgrade the plugin versions once this is merged.

kranich commented 7 months ago

@christoomey ready when you are! ;-)

kranich commented 5 months ago

@christoomey May I try to remind you of this open pull request? You seem to have forgotten about it, but I would still like to get it merged, if possible.