search

christoomey / vim-tmux-navigator

Seamless navigation between tmux panes and vim splits
MIT License
5.07k stars 319 forks source link

fix: when in a "pipenv shell" can't move in between different vim/nvim windows #395

Closed noapoleon closed 2 weeks ago

noapoleon commented 3 weeks ago

Simple regex change that adds pipenv to matches Allows switching panes and vim windows even in a pipenv shell which didn't work before

christoomey commented 3 weeks ago

Hi @noapoleon, thanks for sharing, but I'm concerned about how broad change would be. Would you be up for switching this from changing the core regex to instead adding a troubleshooting section w/ a summary and note about the altered pattern match?

noapoleon commented 3 weeks ago

Hi @noapoleon, thanks for sharing, but I'm concerned about how broad change would be. Would you be up for switching this from changing the core regex to instead adding a troubleshooting section w/ a summary and note about the altered pattern match?

Wow I did not expect such a quick reply, sorry for the wait.

Yeah that's totally fine too and I did think about it, my concern was whenever an update is pushed to this repo and the plugin is updated by a plugin manager like Lazy.vim (what I use) it would probably overwrite the changes no?

For now, a troubleshooting section would be fine but what do you think about being able to pass options in a config file like it's done in neovim with a lazy.nvim? Maybe in the form of a list object and whatever is in it could be concatenated with the regex at runtime, that way it doesn't interfere with the local repos. Another approach could be with an environment variable.

I'm not sure how that could be done across different plugin managers honestly and/or tmux, I'm very new to all of this but I thought I'd drop my idea

noapoleon commented 3 weeks ago

Welp.... Just noticed a bug actually. My change fixed navigation in between different nvim split windows (windows inside a single neovim instance) BUT if you're using tmux and have say a split pane, on the left pipenv shell, on the right a normal shell, you won't be able to navigate in between them with the keybinds... :[

I'll look into this a bit but no promises