search

christoomey / vim-tmux-runner

Vim and tmux, sittin' in a tree...
MIT License
291 stars 37 forks source link

Adding g:VtrBeforeEach to allow ignoring commands in history #69

Closed naps62 closed 5 years ago

naps62 commented 7 years ago

See the doc/vim-tmux-runner.txt for an explanation

In short, this enables me to prepend a space to every command, and configure my shell to ignore those commands in the history file

christoomey commented 7 years ago

Hey @naps62, thanks for sharing this. Couple of questions as I look over it:

  1. If I'm reading this correctly, it looks as though you're setting a space (literal " ") as the default. If we merge this in I'd rather the default be nothing.
  2. Would it be possible to create a mapping / command that did this without adding additional code to the plugin? While I certainly appreciate the effort you went through to produce this, my current goal is to simplify and reduce the code / API size of this plugin (while providing a better foundation).
naps62 commented 7 years ago

@christoomey Hi. To answer your two questions:

  1. Yes, I probably committed that by mistake (but no point in fixing I guess, due to your next question)

  2. I am ok with that, sure. I figured this wouldn't be the best option, but it was the quickest one that came to mind to solve my problem, so I figured I'd submit it, even if as just a way to spark discussion, and maybe come up with a better way to solve this But I'm not sure how I would do what you're suggesting.

PS: I'm currently using VTR mostly through vim-test, so I don't directly control the commands that are being sent

naps62 commented 5 years ago

Closing this due to inactivity. I'm no longer using VTR (in favour of Neoterm), and I'm currently OCD'ing over my list of open PRs

Feel free to grab my changes if necessary :)