changes in Executor to avoid infinite loop when repetition is not RE…

DevD-official commented 1 year ago

Hello @christoph2,

Issue description

For XcpError with action as the fixed number of repeat-counter, the Executor goes into an infinite loop due to the reassignment of the repeater instance.

Proposed changes

When the error code is not the same as the previous error code, handler. actions() is not called.
Along with this cleanup of the class variables is performed in the finally block, to ensure that every Executor call has a clean setup.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] All existing tests passed.

Note: Please review my pull request. Let me know if any corrections should be done.

christoph2 commented 1 year ago

Thanks for your contribution. And yes, there's still work to do on error handling.

tttech-miori commented 1 year ago

Hi @christoph2, @DevD-official,

is that PR fixing my previous reports https://github.com/christoph2/pyxcp/issues/107 and https://github.com/christoph2/pyxcp/issues/108, you think?

I'm going to test new release of course but if that's the case we should probably close these issues

tttech-miori commented 1 year ago

I report that https://github.com/christoph2/pyxcp/issues/108 is fixed, thanks!

christoph2 / pyxcp