search

christophM / interpretable-ml-book

Book about interpretable machine learning
https://christophm.github.io/interpretable-ml-book/
Other
4.73k stars 1.05k forks source link

make a bunch of typo/grammar improvements to 05.1 #287

Closed discdiver closed 2 years ago

christophM commented 2 years ago

Thanks for making the effort to go through the draft. I did not expect anyone to actually discover, and even less to fix typos there. Parts of the things (like CONTINUE HERE) are actually part of my writing process, so they will always be part of the intermediate drafts.

discdiver commented 2 years ago

I thought that might be the case, but it's the live version on the main website right now: https://christophm.github.io/interpretable-ml-book/decomposition.html

See screenshot attached.

On Wed, Sep 1, 2021 at 10:48 AM Christoph Molnar @.***> wrote:

Thanks for making the effort to go through the draft. I did not expect anyone to actually discover, and even less to fix typos there. Parts of the things (like CONTINUE HERE) are actually part of my writing process, so they will always be part of the intermediate drafts.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/christophM/interpretable-ml-book/pull/287#issuecomment-910359314, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2Y3GJDRNUHUUQU4TWDDQ3T7Y4M5ANCNFSM5DC4WGKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

christophM commented 2 years ago

ah lol.

I guess I messed up the transition from TravisCI to Github Actions, or something like that.

Then I guess I will take out the instructions and leave it live for now.

Thanks for pointint that out for me, I did not realize it at all.

discdiver commented 2 years ago

👍

On Wed, Sep 1, 2021 at 11:08 AM Christoph Molnar @.***> wrote:

ah lol.

I guess I messed up the transition from TravisCI to Github Actions, or something like that.

Then I guess I will take out the instructions and leave it live for now.

Thanks for pointint that out for me, I did not realize it at all.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/christophM/interpretable-ml-book/pull/287#issuecomment-910377620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2Y3GPFFBRPII673GHRE3LT7Y6VHANCNFSM5DC4WGKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.