search

christophM / interpretable-ml-book

Book about interpretable machine learning
https://christophm.github.io/interpretable-ml-book/
Other
4.8k stars 1.06k forks source link

TCAV sensitivity sign issue #395

Closed mlai-po closed 6 months ago

mlai-po commented 6 months ago

are the signs correct in this line

If the angle is greater than 90 degrees,
S C , k , l ( x ) will be positive, and if the angle is less than 90 degrees,
S C , k , l ( x ) will be negative.

on this page https://christophm.github.io/interpretable-ml-book/detecting-concepts.html

it seems to me sensitivity should be positive when the angle is smaller than 90 degrees and maximal at angle zero

fangzhouli commented 6 months ago

Hi, thank you for your keen eyes! You are completely right. I have issued a pull request.

Best, Fang

christophM commented 6 months ago

Thanks, both of you!