search

christophebedard / dco-check

Simple DCO check script to be used in any CI
Apache License 2.0
12 stars 6 forks source link

Handle missing commits data in get_commits #100

Closed zyga closed 3 years ago

zyga commented 3 years ago

The function calls get_commits_data which can return None. Handle this by returning an empty list of commits instead of going into the loop processing each commit data.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

codecov[bot] commented 3 years ago

Codecov Report

Merging #100 (47e0f03) into master (cc6cb61) will decrease coverage by 4.86%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   73.12%   68.25%   -4.87%     
==========================================
  Files           2        2              
  Lines         480      482       +2     
  Branches       77       78       +1     
==========================================
- Hits          351      329      -22     
- Misses         98      128      +30     
+ Partials       31       25       -6
Impacted Files Coverage Δ
dco_check/dco_check.py 68.12% <33.33%> (-4.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc6cb61...47e0f03. Read the comment docs.