search

christophebedard / dco-check

Simple DCO check script to be used in any CI
Apache License 2.0
12 stars 6 forks source link

Run mypy as part of tests and fix existing errors #102

Closed christophebedard closed 3 years ago

christophebedard commented 3 years ago

Fixes #95

christophebedard commented 3 years ago

Just to confirm that mypy reports errors with the current state of the repo: https://github.com/christophebedard/dco-check/pull/102/checks?check_run_id=2025549639#step:5:1

I'll then push the commit that fixes them.

codecov[bot] commented 3 years ago

Codecov Report

Merging #102 (e393212) into master (abac583) will decrease coverage by 0.52%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   72.46%   71.94%   -0.53%     
==========================================
  Files           2        2              
  Lines         494      499       +5     
  Branches       83       85       +2     
==========================================
+ Hits          358      359       +1     
+ Misses        102      100       -2     
- Partials       34       40       +6
Impacted Files Coverage Δ
dco_check/dco_check.py 71.83% <16.66%> (-0.53%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abac583...e393212. Read the comment docs.