search

christophebedard / dco-check

Simple DCO check script to be used in any CI
Apache License 2.0
12 stars 6 forks source link

Run mypy in strict mode and add missing type annotations #103

Closed zyga closed 3 years ago

zyga commented 3 years ago

This makes mypy --strict . pass, with the sole exception of setuptools used by setup.py

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

codecov[bot] commented 3 years ago

Codecov Report

Merging #103 (cc3b971) into master (7ea6eec) will decrease coverage by 4.40%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   71.74%   67.33%   -4.41%     
==========================================
  Files           2        2              
  Lines         499      499              
  Branches       85       85              
==========================================
- Hits          358      336      -22     
- Misses        106      136      +30     
+ Partials       35       27       -8
Impacted Files Coverage Δ
dco_check/dco_check.py 67.20% <100.00%> (-4.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ea6eec...cc3b971. Read the comment docs.

christophebedard commented 3 years ago

unfortunately, applying suggestions using the UI doesn't include a sign-off. You could simply squash the commits.