search

christophebedard / dco-check

Simple DCO check script to be used in any CI
Apache License 2.0
13 stars 7 forks source link

Improve handling of env vars and defaults #69

Closed christophebedard closed 4 years ago

christophebedard commented 4 years ago

Use custom argparse actions to handle env vars & args defaults. This moves the handling & logic much closer to the start of execution (inside argparse) and removes the need for complex wrapping/unwrapping logic.

Closes #66

codecov[bot] commented 4 years ago

Codecov Report

Merging #69 into master will decrease coverage by 0.41%. The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   60.65%   60.23%   -0.42%     
==========================================
  Files           2        2              
  Lines         427      420       -7     
  Branches       59       58       -1     
==========================================
- Hits          259      253       -6     
  Misses        156      156              
+ Partials       12       11       -1
Impacted Files Coverage Δ
dco_check/dco_check.py 60.04% <95.65%> (-0.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c58b50...63896b1. Read the comment docs.