search

christophebedard / dco-check

Simple DCO check script to be used in any CI
Apache License 2.0
12 stars 6 forks source link

Simplify conditions and cleanup #83

Closed christophebedard closed 4 years ago

christophebedard commented 4 years ago

These two cases:

Although it doesn't work in all cases, e.g. '' is False.

codecov[bot] commented 4 years ago

Codecov Report

Merging #83 into master will increase coverage by 0.20%. The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   73.12%   73.33%   +0.20%     
==========================================
  Files           2        2              
  Lines         480      480              
  Branches       77       77              
==========================================
+ Hits          351      352       +1     
+ Misses         98       91       -7     
- Partials       31       37       +6
Impacted Files Coverage Δ
dco_check/dco_check.py 73.22% <9.09%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6da7959...0e057eb. Read the comment docs.