search

christophebedard / dco-check

Simple DCO check script to be used in any CI
Apache License 2.0
12 stars 6 forks source link

Return boolean value from is_valid_email #98

Closed zyga closed 3 years ago

zyga commented 3 years ago

The function is documented to return a boolean, but the actual return type is Optional[Match[str]] - either an None is returned or a Match object on text strings.

Explicitly convert the result to a boolean.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

codecov[bot] commented 3 years ago

Codecov Report

Merging #98 (8c43ab3) into master (cc6cb61) will decrease coverage by 4.58%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   73.12%   68.54%   -4.59%     
==========================================
  Files           2        2              
  Lines         480      480              
  Branches       77       77              
==========================================
- Hits          351      329      -22     
- Misses         98      127      +29     
+ Partials       31       24       -7
Impacted Files Coverage Δ
dco_check/dco_check.py 68.41% <100.00%> (-4.61%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc6cb61...8c43ab3. Read the comment docs.