search

christophebedard / dco-check

Simple DCO check script to be used in any CI
Apache License 2.0
12 stars 6 forks source link

Handle missing or corrupted mail in process_commits #99

Closed zyga closed 3 years ago

zyga commented 3 years ago

process_commits calls extract_name_and_email which can return None in when the given text doesn't look like a name and email pair. Handle this case by skipping such entries.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

codecov[bot] commented 3 years ago

Codecov Report

Merging #99 (8c64444) into master (cc6cb61) will decrease coverage by 4.80%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   73.12%   68.32%   -4.81%     
==========================================
  Files           2        2              
  Lines         480      483       +3     
  Branches       77       78       +1     
==========================================
- Hits          351      330      -21     
- Misses         98      128      +30     
+ Partials       31       25       -6
Impacted Files Coverage Δ
dco_check/dco_check.py 68.19% <50.00%> (-4.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc6cb61...8c64444. Read the comment docs.