Closed vjanssens closed 2 days ago
I use yarn, and it works as is. Interestingly, the lock files were previously in the gitignore. I didn't realize this when I ported the library.
To be transparent, I am hesitant to do a PR for npm when I use yarn successfully. Curious to see what others think. I of course have a lock file on my machine which is now part of the source, as I removed them from the gitignore.
Normally the project should stick to only one. Since this project already has a yarn.lock, the install should be with yarn.
I don’t know if theres another reason for using npm install
, otherwise i dont think it is necessary.
Anyway, thanks for the PR.
npm and yarn are mostly interchangeable these days, but agreed you should normally stick with one. I tend to use yarn now as it has some useful performance optimizations and somewhat better support for monorepos.
This fixes
npm install
command failing on main branch, which I also noticed on other PRs currently open. Hopefully this allows to get the other PRs being merged as well to get tests working and continue improvement of the repo.